Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition for replication status #8475

Merged
merged 2 commits into from
Jan 29, 2021
Merged

Fix condition for replication status #8475

merged 2 commits into from
Jan 29, 2021

Conversation

coignetp
Copy link
Contributor

What does this PR do?

Having slave_io_running=False and slave_sql_running=False set the service check as WARNING, but it should be CRITICAL.

Motivation

QA

Additional Notes

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • PR title must be written as a CHANGELOG entry (see why)
  • Files changes must correspond to the primary purpose of the PR as described in the title (small unrelated changes should have their own PR)
  • PR must have changelog/ and integration/ labels attached

@coignetp coignetp requested a review from a team as a code owner January 27, 2021 16:26
@ghost ghost added the integration/mysql label Jan 27, 2021
ChristineTChen
ChristineTChen previously approved these changes Jan 27, 2021
View reviewed changes
florimondmanca
florimondmanca suggested changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed offline, can we add some unit tests for this?

florimondmanca
florimondmanca approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@florimondmanca florimondmanca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@ofek ofek merged commit f6bbebf into master Jan 29, 2021
@ofek ofek deleted the paul/fix-running-crit branch January 29, 2021 14:39
ofek pushed a commit that referenced this pull request Jan 29, 2021
@coignetp @ofek
Fix condition for replication status (#8475)
91c62aa 
* Fix condition for replication status

* Add unit test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofek ofek ofek approved these changes

@florimondmanca florimondmanca florimondmanca approved these changes

@ChristineTChen ChristineTChen ChristineTChen left review comments

Assignees
No one assigned
Labels
integration/mysql
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coignetp @ofek @ChristineTChen @florimondmanca